Skip to content

Conversation

joaoantoniocardoso
Copy link
Member

@joaoantoniocardoso joaoantoniocardoso commented Sep 1, 2025

This is a backport of #3516 into 1.4

Summary by Sourcery

Bug Fixes:

  • Set website_status.error before logging to ensure the error is not always None in check_website

Signed-off-by: Patrick José Pereira <patrickelectric@gmail.com>
Copy link

sourcery-ai bot commented Sep 1, 2025

Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

Backports a fix that ensures website_status.error is set before logging so the correct error message is displayed.

Sequence diagram for website status error handling in check_website

sequenceDiagram
    participant Website
    participant check_website
    participant logger
    participant WebsiteStatus
    participant response
    Website->>check_website: Call check_website(site)
    check_website->>response: Get response
    alt response is online
        check_website->>logger: Log "Online"
        check_website->>WebsiteStatus: Set online = True
    else response is offline
        check_website->>WebsiteStatus: Set error = response.error
        check_website->>logger: Log "Offline: {website_status.error}"
    end
    check_website-->>WebsiteStatus: Return website_status
Loading

Class diagram for WebsiteStatus error attribute update

classDiagram
    class WebsiteStatus {
        +bool online
        +str error
    }
    class response {
        +str error
    }
    WebsiteStatus <.. response : uses error
Loading

File-Level Changes

Change Details Files
Update error assignment order to correctly capture response errors in logs
  • Moved website_status.error = response.error above the logger.warning call
core/services/helper/main.py

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Copy link

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey there - I've reviewed your changes and they look great!


Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@patrickelectric patrickelectric merged commit 3eb6ce5 into bluerobotics:1.4 Sep 1, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants